player/command: fix playlist-remove argument requirement #17066
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playlist-remove has a required index argument, as indicated by the documentation. However, in 332907e MP_CMD_OPT_ARG was mistakenly added, making it optional. The effect of not specifying the argument is defaulting the index to 0 and always removing the first element in the playlist, which is not expected. Fix this by making the argument required. Fixes: 332907e
kasper93
approved these changes
Nov 22, 2025
Member
kasper93
left a comment
kasper93
left a comment
There was a problem hiding this comment.
This is breaking change as some people may depend on this undocumented behavior. But I would say it's fine.
|
Download the artifacts for this pull request: Windows |
Member
|
If it has the potential to break add it to interface-changes at least? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playlist-remove has a required index argument, as indicated by the documentation. However, in 332907e MP_CMD_OPT_ARG was mistakenly added, making it optional. The effect of not specifying the argument is defaulting the index to 0 and always removing the first element in the playlist, which is not expected.
Fix this by making the argument required.
Fixes: 332907e